Add expression balancing for xilinxhls backend #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR is addressing issue #66.
Main changes:
hlt4ml
(see these lines)backends/xilinxhls/firmware/BDT_unrolled.h
score_t scores
array, from:These changes bring a notable improvements in latency (and partially in resource consumption) when using the
AP_SAT
flag in the BDTScorePrecision
, while maintaining performances identical to the current version of conifer in terms of BDT score.Additionally, in commit bffd3a6 I fixed a typo in the "Development instructions" and added
pandas
to thedev_requirements.txt
file.PR Validation
The following tests are done with:
v1.7.5
v2023.2
Latency/Resources table:
master
ap_fixed<11,4,AP_RND_CONV,AP_SAT>
ap_fixed<11,4,AP_RND_CONV,AP_SAT>
master
ap_fixed<11,4,AP_RND_CONV>
ap_fixed<11,4,AP_RND_CONV>
Score plots: