waves: add support for IPC4 compilation, including as LLEXT #9775
+85
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of course, 32 modules must be enough forever, until it isn't. With waves we've hit the limit. Let's raise it to 48, because that certainly will be enough forever. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
With this waves can be built as a part of IPC4 configuration - either linked into the base image or as a LLEXT module. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
reviewed
Jan 14, 2025
| @@ -27,7 +27,7 @@ | |||
| #define EXTENDED_MANIFEST_VERSION_MAJOR 0x0001 | |||
| #define EXTENDED_MANIFEST_VERSION_MINOR 0x0000 | |||
|
|
|||
| #define FW_MAX_EXT_MODULE_NUM 32 | |||
| #define FW_MAX_EXT_MODULE_NUM 48 | |||
There was a problem hiding this comment.
What's the container size ? Lets just set this unlimited.
There was a problem hiding this comment.
@lgirdwood it is used for a fixed-size array inside a structure. So the only alternative would be to count and dynamically allocate
There was a problem hiding this comment.
ack, I think we need the dynamic alloc (with a sane max). Whats the array elem size ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this waves can be built as a part of IPC4 configuration - either linked into the base image or as a LLEXT module.