-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set_xtensa_param.sh: add ZEPHYR_TOOLCHAIN_VARIANT and TOOLCHAIN_VER #8578
Conversation
Rename the variable name used by SOF script with the one expected by the Zephyr build system for simplicity and consistency. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This helps with Zephyr and does not hurt anyone else. Adjust rebuild-testbench.sh accordingly. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Only a temporary GitHub or proxy glitch for just one platform in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8578/build13228782, all other builds were successful. Only the well-known MTL GSC firmware error in https://sof-ci.01.org/sofpr/PR8578/build755/devicetest/index.html, everything else green - even suspend/resume! https://sof-ci.01.org/sofpr/PR8578/build756/devicetest/index.html all green - even suspend/resume! => small, zero functional change good to go. |
*) # The previous, main case/esac already caught invalid input. | ||
# This won't hurt platforms that don't use Zephyr (it's not even | ||
# exported). | ||
ZEPHYR_TOOLCHAIN_VARIANT='xcc';; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the Zephyr toolchain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the Zephyr SDK is normally achieved by NOT using this script...
BTW this is useful for running |
Only one unrelated and isolated proxy /
|
The changes are to scripts not used by the failing Intel CI targets, so proceeding with merge. |
2 commits
It's not perfect yet but it's now more than usable for Zephyr