Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platforms:tgl: Configure format converter for IPC4 when building for Zephyr #5566

Merged
merged 1 commit into from
Mar 23, 2022
Merged

platforms:tgl: Configure format converter for IPC4 when building for Zephyr #5566

merged 1 commit into from
Mar 23, 2022

Conversation

XiaoyunWu6666
Copy link
Contributor

@XiaoyunWu6666 XiaoyunWu6666 commented Mar 18, 2022 •
edited
Loading

Enable format converters when building tgl firmware with Zephyr and IPC4.

Signed-off-by: Iris Wu xiaoyun.wu@intel.com

@XiaoyunWu6666 XiaoyunWu6666 mentioned this pull request Mar 18, 2022
Closed
lgirdwood
lgirdwood reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we disable HiFi3 ?

@RanderWang
Copy link
Collaborator

Why do we disable HiFi3 ?

Currently ipc4 format conversion doesn't support HIFI3, so only generic format conversion is supported. The issue has been temporarily addressed by bf191f6
@XiaoyunWu6666 can you remove HIFI=n and test ?

@lgirdwood
Copy link
Member

@singalsu how much effort to add the HiFi3 PCM converter support ? This will give some parity when testing IPC4 code and topologies on TGL/ADL.

@lgirdwood
Copy link
Member

@XiaoyunWu6666 can you fix the conflict. Thanks.

@singalsu
Copy link
Collaborator

@singalsu how much effort to add the HiFi3 PCM converter support ? This will give some parity when testing IPC4 code and topologies on TGL/ADL.

@RanderWang @lgirdwood Can you provide more details about what is the missing piece in IPC4 HiFi3 pcm conversion. Also I find it hard to test anything IPC4 related, no testbench, no cmocka. E.g. the IPC4 only components.

@lgirdwood
Copy link
Member

@singalsu how much effort to add the HiFi3 PCM converter support ? This will give some parity when testing IPC4 code and topologies on TGL/ADL.

@RanderWang @lgirdwood Can you provide more details about what is the missing piece in IPC4 HiFi3 pcm conversion. Also I find it hard to test anything IPC4 related, no testbench, no cmocka. E.g. the IPC4 only components.

@singalsu IIUC the PCM converter in IPC4 uses HiFi4 and converts all the PCM formats for Windows, but the Hifi3 version is missing some of the format conversions. Please take a quick check of the Hifi4 code and see if the missing conversions are obvious. Thanks

@XiaoyunWu6666
overlays:tgl: Configure format converter for IPC4
b8641c8 
Enable format converters when building tgl firmware with Zephyr
and IPC4.

Signed-off-by: Iris Wu <xiaoyun.wu@intel.com>
@XiaoyunWu6666 XiaoyunWu6666 requested a review from lgirdwood March 22, 2022 14:18
@lgirdwood lgirdwood merged commit 8ebb747 into thesofproject:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanderWang RanderWang RanderWang approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XiaoyunWu6666 @RanderWang @lgirdwood @singalsu