Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: add be pipeline for sdw #5507

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

bardliao
Copy link
Collaborator

Use two separated pipelines for BE and FE.

Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com

Use two separated pipelines for BE and FE.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@@ -85,38 +54,6 @@ Object.Dai {
Object.Base.hw_config."ALH3" {
id 1
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 50: why is the default_hw_confg_id '1'?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the're sonly one hw_config and its ID is 1 on line 55

Copy link
Member

@plbossart plbossart Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but why is the hw_config numbering different for different dais? Is this not defined within the scope of each DAI, in other words we should start at zero.

I guess it's not broken but it looks inconsistent to me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart do you mean other topologies? We blindly set the hw_config ID to match the link ID in the machine driver for no good reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this and make it non ambiguous prior to roll out of topology2. If it not needed we can remove or we should start IDs at 0. We have time to align, @ranj063 are you OK to look at this when convenient ?

@lgirdwood lgirdwood merged commit ccde447 into thesofproject:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants