-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][MTL][HDA] Sporadically Audio glitches on on-board speakers upon unplug of HDMI/DP external display cable #8236
Comments
@syedk008 Thanks for reporting this issue! |
As so far I have not heard this glitch, while I've been playing with MTL RVP and display-audio. It would be nice know some details on how it sounds, or even have a sample of it. Also the connected display/AV-amplifier maybe relevant. |
The [1] https://github.com/thesofproject/sof/blob/main/src/ipc/ipc4/handler.c#L616 can you enable more verbose prints via dyndbg in kernel and also provide a firmware log? I'm not sure what |
Please check the video attachment in the HSD:https://hsdes.intel.com/resource/15014143962. I will get the details of the display. |
@jsarha display is acer kg281k. Steps to reproduce the issue: Reboot with the external display attached, Switch in the audio settings between the internal speaker and the external display. Repeat this several times. @mengdonglin issue can be reproduced with mtl-005 FW as well. currently this parameter (snd-sof ipc4_ignore_cpc=1) is set. @ujfalusi dmesg and firmware logs are attached. Please let me know if you need more logs. |
@syedk008, so the garbled audio is on the analog speaker and not on the HDMI? In the kernel log there is a whole lot going on than just switching the playback back and forth between HDMI and analog speaker.
playback stream 0 is HDA analog |
@ujfalusi yes, we are observing the issue only on analog speakers. |
@syedk008, when the audio is corrupted you can try to use the probes to extract the audio from the firmware at a given point to hear where the glitch is added. I will create an update for the page, but I also followed it more or less. to get the ID that you need to set (sample from upx-i11 and for the analog playback path):
I want to extract the audio from the first gain widget, so the number is 2, because: The important thing is: first crecord, then aplay, then echo |
fwiw, with #8263 the wav file should be correct, no need for the import as raw trick. |
@ujfalusi, are below options enabled by default in the FW? We are using a production key signed Fw, so we can't change the settings and build the same at our end. I will check if we have any pre-production si boards available. |
Is this for v2.7 or mtl-06 as Kconfig may be different, but usually debug items are disabled. |
It's for v2.7. Currently, we do not have a pre-production si board and are in the process of getting one to collect logs for this issue. |
I don't know if it's possible in this case but you should also ask for a system that accepts BOTH firmware images signed with production keys and non production keys. It maybe be possible because I've seen it in at least in one example in the past. Ideally it should be possible. BTW "pre-production" is very poor terminology. It should be called "development" which obviously does not stop the minute production starts. |
I think we managed to reproduce this on the MTL RVP we have at Espoo lab. There is no need to plug and unplug HDMI cable. Just play 16-bit audio first to analog PCM (hw:0,0), then to HDMI (hw:0,3), and again to analog. Usually on the first cycle the Here is one example sequence and the related kernel log. The audio was Ok on third playback, but was broken on 5th:
|
A fix is submitted: zephyrproject-rtos/zephyr#63784 |
@syedk008, can you try that patch on your setup? |
Update Zephyr to use thesofproject/zephyr/stable-v2.7 with following one commit backported from Zephyr main. 3c58926487eb drivers: dma: intel-adsp-hda: Correct DGCS:SCS bit for Link: thesofproject#8236 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@syedk008 are we pending any further testing or can we close ? |
Fix has been merged on Zephyr main branch, closing this bug. |
Update Zephyr to use thesofproject/zephyr/stable-v2.7 with following commits backported from Zephyr main. 3c58926487eb drivers: dma: intel-adsp-hda: Correct DGCS:SCS bit for feaa6281b7fc drivers: hda: insert an empty ";" statement before Link: thesofproject#8236 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Update Zephyr to use thesofproject/zephyr/stable-v2.7 with following commits backported from Zephyr main. 3c58926487eb drivers: dma: intel-adsp-hda: Correct DGCS:SCS bit for feaa6281b7fc drivers: hda: insert an empty ";" statement before Link: thesofproject#8236 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Update Zephyr to use thesofproject/zephyr/stable-v2.7 with following commits backported from Zephyr main. 3c58926487eb drivers: dma: intel-adsp-hda: Correct DGCS:SCS bit for feaa6281b7fc drivers: hda: insert an empty ";" statement before Link: #8236 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Describe the bug
Sporadically glitches were observed on speakers during playback when HDMI external display was disconnected.
To Reproduce
Reproduction Rate
50%
Expected behavior
No glitches should be present during playback.
Impact
showstopper
Environment
log
Updated the log file.
dmesg_log.txt
The text was updated successfully, but these errors were encountered: