Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CockroachDB driver #225

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat: add CockroachDB driver #225

merged 1 commit into from
Nov 17, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 16, 2024
Copy link
Contributor

github-actions bot commented Nov 16, 2024

🐰 Bencher Report

Branchadd-cockroachdb-driver
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
825,980,000.00
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
831,190,000.00
rusqlite📈 view plot
⚠️ NO THRESHOLD
4,468,000.00
sqlite📈 view plot
⚠️ NO THRESHOLD
4,805,400.00
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (131e899) to head (ccc43ea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rsql_drivers/src/cockroachdb/driver.rs 65.38% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   93.79%   93.50%   -0.30%     
==========================================
  Files          94       95       +1     
  Lines       12680    12251     -429     
==========================================
- Hits        11893    11455     -438     
- Misses        787      796       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman force-pushed the add-cockroachdb-driver branch 5 times, most recently from 668d72c to a5a6161 Compare November 17, 2024 00:20
@brianheineman brianheineman merged commit 8bbe7b6 into main Nov 17, 2024
12 of 14 checks passed
@brianheineman brianheineman deleted the add-cockroachdb-driver branch November 17, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant