Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic autocomplete of table names where metadata is available. … #193

Merged
merged 21 commits into from
Oct 5, 2024

Conversation

gazure
Copy link
Contributor

@gazure gazure commented Sep 20, 2024

Describe the pull request

First pass at implementing a sql completer specified by #188

added a setting to enable/disable new completions.

…add toggleShellCommand in effort to reduce boilerplate, add completions toggle command
@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 95.60853% with 35 lines in your changes missing coverage. Please review.

Project coverage is 93.81%. Comparing base (78477a7) to head (6d8683b).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
rsql_core/src/shell/completer.rs 95.37% 23 Missing ⚠️
rsql_drivers/src/metadata.rs 80.95% 8 Missing ⚠️
rsql_drivers/src/connection.rs 95.23% 2 Missing ⚠️
rsql_core/src/shell/repl.rs 93.75% 1 Missing ⚠️
rsql_drivers/src/snowflake/driver.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   93.30%   93.81%   +0.51%     
==========================================
  Files          93       94       +1     
  Lines       11912    12678     +766     
==========================================
+ Hits        11114    11894     +780     
+ Misses        798      784      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gazure gazure marked this pull request as ready for review October 3, 2024 18:38
@brianheineman
Copy link
Contributor

Thanks for the PR! 🎉

@brianheineman brianheineman merged commit e8c6aec into theseus-rs:main Oct 5, 2024
13 of 14 checks passed
@gazure gazure deleted the basic-auto-complete branch October 5, 2024 17:00
@gazure
Copy link
Contributor Author

gazure commented Oct 5, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants