-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to find countries based on the calling codes #39
Conversation
…ow-multiple-country-per-ISO Adds multiple country/ISO support
see therebelrobot#35 for precedent
Hey @YouriT! I'm actually gonna be seeing about releasing v2 today, which will change a large portion of the codebase. I like this idea though, and will take a look at implementing it in the next version, I just don't know how mergable this will be after that lands. |
Thanks :) well to make it easy, I will take a look at your new code base to integrate this PR or a likewise. I don't know if you thought about some indexing but it could be nice for searching through the dataset? Personally, I'm not a big fan of O(n) loops when trying to access something quickly. I might be able to deliver it too but I prefer doing it if you could consider merging that feature too? |
Take a look at the code in |
PR here: #40 Still need to fix linting and see what's failing in the tests. |
Yeah linting just burned my eyes! I made the changes, trying to write the tests but I never used tape, checking that quickly out |
…ryjs into pre-release/v2.0.0
Okay, I merged v2 with my PR. Tests passed on my side properly. Tell me if I missed something |
Btw, I saw that |
Yeah, it'll be changed to tape. I've neglected this lib for far too long. Tonight I'll be busting out all what's left/needed for this. |
I'm adding some tests, nevertheless, there is a massive breaking change with the responses of the queries. You think that's ok to push it with this new behaviour? I mean, is it mandatory to break that? |
@YouriT That's why the version will be a major version bump per SemVer. This new behavior allows for searches to return multiple sets of results based if, for example, searching by That being said, this discussion should probably be done over on the PR for |
I needed that and therefore would love to see it integrated if possible. If it is I will add the according doc!