Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing ISO information for some countries #20

Merged
merged 1 commit into from
Apr 14, 2015

Conversation

moimikey
Copy link
Collaborator

notes

  • this adds some missing ISO codes for v2 release - Country rebuild - ISOs missing, countries not accurate #19
  • the british virgin islands ISO needs to be edited. It's not actually correct... will probably wanna edit that later.
  • removed Yugoslavia, as it's not a country anymore
  • individual json files for "regions" aren't so uniform. Like wales.json had the correct information, but lacked the GBR ISO codes. ditto for some other UK regions.

I do thing the DB needs to be rebuilt though. theres some discrepancies here and there. FWIW, https://github.com/OpenBookPrices/country-data has raw csv and json that could be used.

@therebelrobot
Copy link
Owner

Downloaded it, ran tests, and in my professional opinion:

LGTM

therebelrobot added a commit that referenced this pull request Apr 14, 2015
adds missing ISO information for some countries
@therebelrobot therebelrobot merged commit b60b672 into therebelrobot:master Apr 14, 2015
@moimikey moimikey deleted the missing-isos branch April 14, 2015 16:45
@moimikey
Copy link
Collaborator Author

totally stealing that gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants