Refine inline parsing #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing in a `string $match` parameter, we've undone that BC-break and instead expose match information via the context. This approach gives us some flexibility and makes it easier for developers to use the already-known match data to avoid expense regex matching of their own.
| 'symbol' => '@', | ||
| 'regex' => '/^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}(?!\w)/', | ||
| 'prefix' => '@', | ||
| 'regex' => '[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}(?!\w)', |
There was a problem hiding this comment.
Why are we still including a prefix? Shouldn't this just be part of the regex now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the changes from #550 and #551 to the next level 😉
Based on @MarkCarver's feedback, we're removing the
string $matchparameter fromInlineParserInterface::parse()and instead exposing the matches via the context. This also now includes sub-matches from regex capturing groups.