-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec 0.26 #260
Merged
Merged
Spec 0.26 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinodell
added
spec compliance
Issues or question about compliance with the CommonMark or GFM specs
on hold
We're not quite ready for this yet
labels
Aug 12, 2016
Mirrors jgm/commonmark.js#36e8d5c
Mirrors jgm/commonmark.js#d9e01bf
…ith 1. Mirrors jgm/commonmark.js#ee96bee
Mirrors jgm/commonmark.js#914491e
Mirrors jgm/commonmark.js#d2cb993
This implements the rule that we can't have emphasis matches when (a) one of the delimiters can open AND can close, and (b) the sum of the lengths of the delimiter runs containing open and close delimiters is a multiple of 3. Mirrors jgm/commonmark.js#fd21a0a
This reverts commit 2dc2183.
The tests are segfaulting with PHP 7.1 Beta3, so let's ignore those failures for now. We'll remove this once 7.1 becomes stable.
Appveyor (for Windows testing) is failing on the bin tests. I'll merge this for now and investigate that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a work in progress.
Remaining tasks: