Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec 0.26 #260

Merged
merged 13 commits into from
Aug 28, 2016
Merged

Spec 0.26 #260

merged 13 commits into from
Aug 28, 2016

Conversation

colinodell
Copy link
Member

@colinodell colinodell commented Aug 12, 2016

This branch is a work in progress.

Remaining tasks:

  • Fix test failures
  • Add regression tests (if needed)
  • Re-review changes
  • Check Scrutinizer for any quality issues
  • Document any BC breaks
  • Update the changelog
  • Test commonmark-extras

@colinodell colinodell added spec compliance Issues or question about compliance with the CommonMark or GFM specs on hold We're not quite ready for this yet labels Aug 12, 2016
@colinodell colinodell self-assigned this Aug 12, 2016
Mirrors jgm/commonmark.js#36e8d5c
Mirrors jgm/commonmark.js#d9e01bf
Mirrors jgm/commonmark.js#914491e
Mirrors jgm/commonmark.js#d2cb993
This implements the rule that we can't have emphasis matches
when (a) one of the delimiters can open AND can close, and (b)
the sum of the lengths of the delimiter runs containing open
and close delimiters is a multiple of 3.

Mirrors jgm/commonmark.js#fd21a0a
The tests are segfaulting with PHP 7.1 Beta3, so let's ignore those failures
for now. We'll remove this once 7.1 becomes stable.
@colinodell colinodell changed the title WIP: Spec 0.26 Spec 0.26 Aug 28, 2016
@colinodell colinodell removed the on hold We're not quite ready for this yet label Aug 28, 2016
@colinodell
Copy link
Member Author

Appveyor (for Windows testing) is failing on the bin tests. I'll merge this for now and investigate that separately.

@colinodell colinodell merged commit 8a19b99 into master Aug 28, 2016
@colinodell colinodell deleted the spec-0.26 branch August 28, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec compliance Issues or question about compliance with the CommonMark or GFM specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants