Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failing tests for lists with tabs #258

Closed
wants to merge 1 commit into from
Closed

Added failing tests for lists with tabs #258

wants to merge 1 commit into from

Conversation

onigoetz
Copy link
Contributor

Hi,

A user of a project I work on reported me an issue about not being able to use tabs in lists anymore. (justinwalsh/daux.io#376)

I can confirm that it is currently the case, as you can see with the tests I added to this Pull Request.

The test fails with :

--- Expected
+++ Actual
@@ @@
 <li>foo
-<ul>
-<li>bar</li>
-</ul>
-</li>
+       * bar</li>
 </ul>
 <hr />
 <hr />
 <ul>
 <li>foo
 <ul>
 <li>bar</li>
 </ul>
 </li>
 </ul>
 '

I would really like to help and contribute a fix but I'm afraid I really have no idea where to start looking for.

From what I was able to track down, the feature is broken since the Pull Request #234 was merged.

@onigoetz
Copy link
Contributor Author

onigoetz commented Aug 5, 2016

@colinodell Do you have an idea how we could fix this ?

@colinodell
Copy link
Member

Sorry for the delay in responding to this - it must've slipped through my inbox. I'll take a look at this tonight or tomorrow.

@colinodell colinodell self-assigned this Aug 5, 2016
@colinodell colinodell added the bug Something isn't working right label Aug 5, 2016
colinodell added a commit that referenced this pull request Aug 28, 2016
This rebases PR #258 onto the lastest `master` branch.
@colinodell
Copy link
Member

I figured out the issue. One of the parsers was performing some operations on the Cursor and then tried to restore it to its original state. However, when saving/restoring the state, I totally forgot to include an important variable that tracks tab indentation. As a result, the Cursor was never restored to the proper state which caused some indentation issues.

I resolved the issue (see 4c625f3) and merged it into master. I then rebased your regression tests onto master via 75e0e68. The failing tests you submitted are now passing.

Thanks for your help and patience!

Fixed; closed.

@colinodell colinodell closed this Aug 28, 2016
@onigoetz
Copy link
Contributor Author

onigoetz commented Aug 28, 2016

This is awesome, thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants