Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian in markdown #78

Closed
mikield opened this issue Feb 27, 2015 · 2 comments
Closed

Russian in markdown #78

mikield opened this issue Feb 27, 2015 · 2 comments
Assignees
Labels
bug Something isn't working right
Milestone

Comments

@mikield
Copy link

mikield commented Feb 27, 2015

Russian text with <code> renders like:

  • Из: твоя оя featu ветка
  • But must render like:

  • Из: твоя feature ветка
  • It repeats some symbols.

    When in line are only english sybmols - is OK

    @colinodell
    Copy link
    Member

    Thanks for reporting this bug! We'll take a look at this.

    Would you be able to post the exact Markdown that causes this issue? I could probably figure it out myself, but if you have it handy that makes my life a bit easier :) Simply indent it with 4 spaces like this:

    See how `GitHub` doesn't try parsing <code>this</code> as **Markdown**?
    

    @colinodell colinodell added the bug Something isn't working right label Feb 27, 2015
    @colinodell colinodell added this to the Version 0.7.1 milestone Feb 27, 2015
    @colinodell colinodell self-assigned this Feb 27, 2015
    @colinodell
    Copy link
    Member

    The Cursor class wasn't properly calculating string positions with Russian characters (or any multi-byte characters for that matter). I've implemented a solution which resolves the issue. I was also able to identify a couple other troublesome areas - these have also been corrected.

    These fixes will be part of the 0.7.1 release coming soon :)

    Thanks again for reporting this issue!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bug Something isn't working right
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants