Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: ordered lists starting with 0 #74

Closed
martonbognar opened this issue Feb 22, 2015 · 4 comments
Closed

Question: ordered lists starting with 0 #74

martonbognar opened this issue Feb 22, 2015 · 4 comments
Labels
bug Something isn't working right good first issue An easy issue for new collaborators
Milestone

Comments

@martonbognar
Copy link

If I'm not mistaken, ordered lists starting with any positive number will have the start='N' attribute, but this is not the case when starting a list with 0, it will simply start it at the default 1.

Is this expected behavior based on the spec (I did not see any rules prohibiting it, but I could be wrong), and would you consider adding it as a feature? I think it would be beneficial seeing how especially in areas related to computing often indexes begin with a 0.

@colinodell colinodell added the question General questions about the project or usage label Feb 22, 2015
@colinodell
Copy link
Member

That's a great question - let me look into this and get back to you.

@colinodell
Copy link
Member

I've re-read the spec and came to the same conclusion as you - 0. is definitely a valid ordered list marker, so the start attribute should be set to 0. I'll work on implementing a fix for this.

I've also filed an issue "upstream" with the JS implementation that we're based off: commonmark/commonmark.js#10

Thanks for letting us know about this!

@colinodell colinodell added bug Something isn't working right good first issue An easy issue for new collaborators and removed question General questions about the project or usage labels Feb 24, 2015
@colinodell colinodell added this to the Version 0.8 milestone Feb 25, 2015
@colinodell
Copy link
Member

This has been fixed. Thanks!

@martonbognar
Copy link
Author

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right good first issue An easy issue for new collaborators
Projects
None yet
Development

No branches or pull requests

2 participants