feat: Support requirements overrides files #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this seems reasonable, I can update docs to give an example. |
|
@mitch815 What do you think of this? |
68069fc to
ddcdfce
Compare
ddcdfce to
19e53c8
Compare
|
I think a simple explanation to the attr is good enough in the doc. Please let me if that is not the case. |
mitch815
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
#128 gives a workaround, but it only works when the overrides file is at the root because
argsdoes not seem to support Predefined source/output path variables.This PR makes
requirements_overridesas a dedicated attr so in the rule can access itsshort_path.