Add test size option #180
Merged
Add test size option #180
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hofbi
commented
Dec 11, 2024
| @@ -43,6 +45,7 @@ def pip_compile( | |||
| requirements_in = requirements_in or "//:requirements.in" | |||
| requirements_txt = requirements_txt or "//:requirements.txt" | |||
| tags = tags or [] | |||
| size = size or "small" | |||
There was a problem hiding this comment.
@mark-thm Choosing small as the default since this will most likely match the expected size of the test according to https://bazel.build/reference/be/common-definitions#common-attributes-tests
There was a problem hiding this comment.
The default test size in bazel is "medium", and this was the size set on pip_compile_test tests before this pull request. Changing the default to "small" led to test timeouts for me.
Also,pip_compile_test is, in my opinion, an integration tests, since is involves querying the index, so the default of "medium" is justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #173