Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove FeeBreakdownSection from Editor modal #4250

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Feb 4, 2025

We've decided that -

  • the fee breakdown will always display where possible
  • we don't need to explain or configure anything in the modal - this can live in Notion without issue. If we get more feedback here we can link to Notion (like we do with Calculate → MathJS).

In reality, almost all services will be going through the osl/fee-calculator flow so this should "just work"!

@DafyddLlyr DafyddLlyr requested a review from a team February 4, 2025 09:54
Copy link

github-actions bot commented Feb 4, 2025

Removed vultr server and associated DNS entries

<InviteToPaySection/>
<FeeBreakdownSection/>
<GovPayMetadataSection />
<InviteToPaySection />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small unrelated nit: have often thought that these final existing sections should be swapped ! Eg invite to pay first because impacts public form, then more information because similarly public facing, then Gov Pay metadata last (or before internal notes) because behind-the-scenes/internal only . Recognise this is totally outside of scope here though, maybe disorienting to change for current users !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great shout! Done ✅

@DafyddLlyr DafyddLlyr merged commit 7dfbc7d into main Feb 4, 2025
13 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-fee-breakdown-editor-section branch February 4, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants