chore: bump planx-core (multiple schemas support) #4206
Conversation
|
Removed vultr server and associated DNS entries |
…ss/bump-planx-core-3b39b02
…ss/bump-planx-core-3b39b02
| } else { | ||
| nodeIds?.map(([nodeId, _nodeData]) => nodeId); | ||
| return nodeIds?.map(([nodeId, _nodeData]) => nodeId)?.length; |
There was a problem hiding this comment.
These changes are unrelated to the most recent planx-core change, but came across them when investigating why the validate.test.ts tests were still passing without a mock in this module - spotted a data field issue & additionally added test coverage ! (Data field issue does not impact current live usage of these helper functions, but likely would have cropped up next time we try to use elsewhere!)
| .fn() | ||
| .mockImplementation(() => ["ldc", "ldc.p", "ldc.e", "pp", "pa"]), | ||
| }; | ||
| }); |
There was a problem hiding this comment.
These mocks resolve questions raised earlier here: https://opensystemslab.slack.com/archives/C01E3AC0C03/p1737996349338569
When testing the route via supertest, then getValidSchemaValues and planx-core will be called "for real" and not require a mock (eg see modules/flows/validate/validate.test.ts >> describe("ODP Schema file type validation on diff"), but when simply unit testing like here we need to mock & include partial, realistic mockImplementation return values.
| Boolean(props.type !== TextInputType.Short && characterCountLimit); | ||
| const displayCharacterCount = Boolean( | ||
| props.type !== TextInputType.Short && characterCountLimit, | ||
| ); |
There was a problem hiding this comment.
These are linting changes only picked up below here after a rebase to main - sorry for extra noise !
…ss/bump-planx-core-3b39b02
There was a problem hiding this comment.
Finally took a look at the planx-core PR, all looking good. One key comment here which is worth mulling over maybe - theopensystemslab/planx-core#629 (comment)
Done a code-only review, all looking great ✅
Working through the testing notes now, will update PR when done.
There was a problem hiding this comment.
Appreciate the extra coverage here 👍
| if (type === ComponentType.Answer) { | ||
| return nodeIds.some(([, nodeData]) => nodeData?.data?.val === fn); |
Relies on theopensystemslab/planx-core#629
Testing:
I've pre-loaded some submitted session data from staging onto this pizza so that we can easily review sample payloads using the following admin endpoints:
preApphttps://api.4206.planx.pizza/admin/session/6ece5b06-d83d-4258-a184-d77b7350c99f/digital-planning-applicationmetadata.schemapoints topreApplication.json, anddata.applicationhas preApp-unique fields like "harmful" & "sensitive"applicationpayload - now it's specifiically apreApppayload which is the key change here!ldc.phttps://api.4206.planx.pizza/admin/session/3fcc7f52-9409-45f7-8ea2-b6b0c1bf2ffd/digital-planning-applicationmetadata.schemapoints toapplication.jsondiscretionary (breach)https://api.4206.planx.pizza/admin/session/9bb50c1f-1945-4e17-9867-ccadec9c6a91/digital-planning-application?skipValidation=trueskipValidation=truebecause not statutory, confirm thatmetadata.schemapoints toapplication.jsonOther schema-dependent editor features to review on the pizza: