New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ESM-compatible `__dirname` reference in e2e/tests/api-driven #4111

Merged

jessicamcinchak merged 1 commit into main from jess/e2e-api-dirname-esm-bug

Jan 7, 2025

Member

jessicamcinchak commented Jan 7, 2025 •

edited

Loading

Should fix ReferenceError: __dirname is not defined thrown by nightly regression tests here https://github.com/theopensystemslab/planx-new/commit/2984d2a8708a6daaa63b23d5530a5b978a4ff00f/checks

Regression tests passing against this branch here ✔️ https://github.com/theopensystemslab/planx-new/actions/runs/12646931097


          fix dirname usage

196ea62

github-actions bot commented Jan 7, 2025 •

edited

Loading

Removed vultr server and associated DNS entries

jessicamcinchak requested a review from a team

January 7, 2025 07:45

DafyddLlyr approved these changes

View reviewed changes

jessicamcinchak merged commit 9ab99a3 into main

17 checks passed

jessicamcinchak deleted the jess/e2e-api-dirname-esm-bug branch

January 7, 2025 09:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet