add test for SetValue and mock for getValidSchemaValues

remove appTypeCheckMocks

shift order of service.ts in publish

set user role for publish.test first publish test

add formatting back to publish.test

refine test return of schema values

api.planx.uk/modules/flows/publish/helpers.test.ts

@@ -5,6 +5,14 @@ import {
 import { hasStatutoryApplicationType } from "./helpers.js";
 
 describe("hasStatutoryApplicationPath", () => {
+  beforeAll(() => {
+    vi.mock("@opensystemslab/planx-core", () => {
+      return {
+        getValidSchemaValues: vi.fn().mockImplementation(() => ["ldc"]),
+      };
+    });
+  });
+
   test("returns false for a flow that doesn't have a Send", () => {
     expect(hasStatutoryApplicationType(mockStatutoryFlowWithoutSend)).toEqual(
       false,

api.planx.uk/modules/flows/publish/publish.test.ts

@@ -82,10 +82,8 @@ describe("publish", () => {
         },
       },
     });
-    await supertest(app)
-      .post("/flows/1/publish")
-      .set(authHeader({ role: "platformAdmin" }))
-      .expect(200);
+
+    await supertest(app).post("/flows/1/publish").set(auth).expect(200);
   });
 
   it("does not update if there are no new changes", async () => {

api.planx.uk/modules/flows/publish/service.ts

@@ -9,6 +9,7 @@ import {
 import { userContext } from "../../auth/middleware.js";
 import { getClient } from "../../../client/index.js";
 import { hasComponentType } from "../validate/helpers.js";
+import { hasStatutoryApplicationType } from "./helpers.js";
 
 interface PublishFlow {
   publishedFlow: {
@@ -26,11 +27,14 @@ export const publishFlow = async (flowId: string, summary?: string) => {
 
   const flattenedFlow = await dataMerged(flowId);
   const mostRecent = await getMostRecentPublishedFlow(flowId);
-  const hasSendComponent = hasComponentType(flattenedFlow, ComponentType.Send);
   const delta = jsondiffpatch.diff(mostRecent, flattenedFlow);
 
   if (!delta) return null;
 
+  const hasSendComponent = hasComponentType(flattenedFlow, ComponentType.Send);
+  const isStatutoryApplication =
+    hasSendComponent && hasStatutoryApplicationType(flattenedFlow);
+
   const { client: $client } = getClient();
   const response = await $client.request<PublishFlow>(
     gql`
@@ -67,7 +71,7 @@ export const publishFlow = async (flowId: string, summary?: string) => {
       publisher_id: parseInt(userId),
       summary: summary ?? null,
       has_send_component: hasSendComponent,
-      is_statutory_application_type: false,
+      is_statutory_application_type: isStatutoryApplication,
     },
   );