Merge pull request #3995 from thematters/feat/truncate-link

feat(editor): truncate long link text on publish or edit article
thematters · Jun 14, 2024 · 448f48b · 448f48b
2 parents fd47716 + e71bcaf
commit 448f48b
Show file tree

Hide file tree

Showing 6 changed files with 304 additions and 266 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "@keyv/redis": "^2.6.1",
     "@matters/apollo-response-cache": "^2.0.0-alpha.0",
     "@matters/ipns-site-generator": "^0.1.6",
-    "@matters/matters-editor": "^0.2.5-alpha.0",
+    "@matters/matters-editor": "^0.2.5-alpha.6",
     "@matters/passport-likecoin": "^1.0.0",
     "@matters/slugify": "^0.7.3",
     "@sendgrid/helpers": "^7.7.0",

diff --git a/src/common/enums/index.ts b/src/common/enums/index.ts
@@ -233,6 +233,8 @@ export enum ActivityType {
   UserAddArticleTagActivity = 'UserAddArticleTagActivity',
 }
 
+export const MAX_CONTENT_LINK_TEXT_LENGTH = 20
+
 export const MAX_ARTICLE_TITLE_LENGTH = 100
 export const MAX_ARTICLE_SUMMARY_LENGTH = 200
 export const MAX_ARTICLE_CONTENT_LENGTH = 50e3

diff --git a/src/connectors/queue/migration.ts b/src/connectors/queue/migration.ts
@@ -8,6 +8,7 @@ import {
 
 import {
   ASSET_TYPE,
+  MAX_CONTENT_LINK_TEXT_LENGTH,
   MIGRATION_DELAY,
   MIGTATION_SOURCE,
   QUEUE_CONCURRENCY,
@@ -129,7 +130,13 @@ export class MigrationQueue extends BaseQueue {
                       sanitizeHTML(content, {
                         maxHardBreaks: -1,
                         maxSoftBreaks: -1,
-                      })
+                      }),
+                      {
+                        truncate: {
+                          maxLength: MAX_CONTENT_LINK_TEXT_LENGTH,
+                          keepProtocol: false,
+                        },
+                      }
                     ),
                 })
 

diff --git a/src/mutations/article/editArticle.ts b/src/mutations/article/editArticle.ts
@@ -19,6 +19,7 @@ import {
   MAX_ARTICLE_REVISION_COUNT,
   NODE_TYPES,
   USER_STATE,
+  MAX_CONTENT_LINK_TEXT_LENGTH,
 } from 'common/enums'
 import {
   ArticleNotFoundError,
@@ -317,7 +318,13 @@ const resolver: GQLMutationResolvers['editArticle'] = async (
     const { content: lastContent } =
       await atomService.articleContentIdLoader.load(articleVersion.contentId)
     const processed = normalizeArticleHTML(
-      sanitizeHTML(content, { maxHardBreaks: -1, maxSoftBreaks: -1 })
+      sanitizeHTML(content, { maxHardBreaks: -1, maxSoftBreaks: -1 }),
+      {
+        truncate: {
+          maxLength: MAX_CONTENT_LINK_TEXT_LENGTH,
+          keepProtocol: false,
+        },
+      }
     )
     const changed = processed !== lastContent
 

diff --git a/src/mutations/article/publishArticle.ts b/src/mutations/article/publishArticle.ts
@@ -1,6 +1,15 @@
 import type { GQLMutationResolvers } from 'definitions'
 
-import { PUBLISH_STATE, USER_STATE } from 'common/enums'
+import {
+  normalizeArticleHTML,
+  sanitizeHTML,
+} from '@matters/matters-editor/transformers'
+
+import {
+  MAX_CONTENT_LINK_TEXT_LENGTH,
+  PUBLISH_STATE,
+  USER_STATE,
+} from 'common/enums'
 import {
   DraftNotFoundError,
   ForbiddenByStateError,
@@ -58,6 +67,15 @@ const resolver: GQLMutationResolvers['publishArticle'] = async (
   }
 
   const draftPending = await draftService.baseUpdate(draft.id, {
+    content: normalizeArticleHTML(
+      sanitizeHTML(draft.content, { maxHardBreaks: -1, maxSoftBreaks: -1 }),
+      {
+        truncate: {
+          maxLength: MAX_CONTENT_LINK_TEXT_LENGTH,
+          keepProtocol: false,
+        },
+      }
+    ),
     publishState: PUBLISH_STATE.pending,
     iscnPublish,
   })