-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate (and attempt one last fixing) documentations around Heroku and Passenger #61
Conversation
color: #a94442; | ||
background-color: #f2dede; | ||
border-color: #ebccd1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simple copy-paste of Bootstrap defaults, just like previous definition (.alert-warning
). I'm not planning on making this more religiously clean as other improvements of this will take over during doc improvements.
Why not just delete it? |
@YaManiKill I will eventually, soon, as part of a bigger improvement of install docs. But until I do, this gives a bit of heads-up to whomever is using that or planning to do so (I doubt it) and makes sure that the latest revision in the git history is up to date with version at the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, well these look fine then.
Why is that? I've been using Shout on a free (legacy) Heroku dyno, with a pinging service as a workaround to prevent sleeping. Is there another reason why it won't work? |
Hi @dideler, thanks for stopping by! Main reason why we are deprecating this segment of the documentation is that no one in the team currently uses Heroku. So maintenance and testing would be done rather hypothetically. Considering the warning in the doc that we inherited from Shout, we preferred to separate from it. I have never used Heroku so I don't know the details, but requiring a pinging service to work around a limitation of the system feels a bit wonky, I'm not sure we really want to recommend this in the official documentation, don't you think? That being said, it's hard to estimate how many people out there are relying on which part of the documentation, and I kinda counted on these deprecation notices to make people come out of the dark :) What's your opinion: should we keep this documentation around while informing it is not well-maintained and may require some hacking around, or can we expect users of Heroku to know what they're doing? |
I agree. Heroku's free plan is great for trying out Lounge, but the client loses connectivity every now and then (due to the dyno going to sleep), unless you use a service to keep it awake. Heroku also offers a hobby plan for $7 which doesn't have this problem.
I would prefer to keep it around with some warnings. Heroku's audience is primarily devs who don't want to spend too much time provisioning a server, and having users figure it out on their own goes against that. FWIW yesterday I got Lounge to work on Heroku. The guide wasn't sufficient. Here's what I had to do (in reverse chronological order): http://pastebin.com/Tnm5hr3j. I'm not sure if some of those steps are the best approach (e.g. installing dev deps) but they fixed the issues I came across. |
Good job! 😄
Ideally, this document should install versions packaged in npm rather than clone the repo + run |
Agreed this would be ideal, but I'm not sure if it would be I can't commit yet to maintaining the Heroku docs, but if I can figure out a reasonable way to deploy Lounge on Heroku then I'll update the docs. Thanks for the offer :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
First of many steps of my master plan to resurrect our docs. I'll open PRs as I go.
We will not be maintaining these anymore. Some of the reasons include: