Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App post renderer #255

Merged
merged 2 commits into from
Jun 6, 2022
Merged

App post renderer #255

merged 2 commits into from
Jun 6, 2022

Conversation

koncar
Copy link
Contributor

@koncar koncar commented May 31, 2022 •
edited
Loading

Description

Add the ability to have multiple post renders

App postrender is done per application deployment version

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@koncar koncar force-pushed the app-post-renderer branch from 9f130c4 to 8906f86 Compare June 3, 2022 10:44
@koncar koncar force-pushed the app-post-renderer branch from 0ae4ce6 to 87acc9c Compare June 3, 2022 13:58
aleksej-paschenko
aleksej-paschenko approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

internal/chart/post_render.go Show resolved Hide resolved
@koncar koncar merged commit 4105c20 into main Jun 6, 2022
@koncar koncar deleted the app-post-renderer branch June 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksej-paschenko aleksej-paschenko aleksej-paschenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koncar @aleksej-paschenko