Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shipa-2799] - Starting process via Ketch CLI outputs "Successfully started!" when passing invalid process name #254

Merged
merged 3 commits into from
May 26, 2022

Conversation

kavinaravind
Copy link
Contributor

Description

This addresses the following bug:

When passing invalid process name to app stop, correct output is shown (process not found) When passing invalid process name to app start the app does not start as expected, but the output shows “Successfully started!”

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

@kavinaravind kavinaravind changed the title modified Start process via selector bug Shipa-2799 May 25, 2022
@kavinaravind kavinaravind changed the title Shipa-2799 Shipa 2799 May 25, 2022
@kavinaravind kavinaravind changed the title Shipa 2799 [shipa-2799] - Starting process via Ketch CLI outputs "Successfully started!" when passing invalid process name May 25, 2022
Copy link
Contributor

@stinkyfingers stinkyfingers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I noticed that when it correctly fails to start, it says "failed to stop app." May want to change the string here too: https://github.com/theketchio/ketch/blob/main/cmd/ketch/app_start.go#L59

@kavinaravind kavinaravind merged commit f4c27d4 into main May 26, 2022
@kavinaravind kavinaravind deleted the shipa-2799 branch May 26, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants