[SHIPA-2627] omit default backoffLimit value #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8695b to
1436529
Compare
1436529 to
11a82f2
Compare
fix tests & template nil check adds tests add tests
11a82f2 to
15f11c4
Compare
stinkyfingers
commented
Mar 30, 2022
| @@ -0,0 +1,72 @@ | |||
| package v1beta1 | |||
There was a problem hiding this comment.
Added these tests just to keep coverage up. Coverage dipped in a couple packages.
DavisFrench
reviewed
Mar 30, 2022
| @@ -109,6 +110,24 @@ func TestJobListNames(t *testing.T) { | |||
| }, | |||
| wantOut: []string{"hello"}, | |||
| }, | |||
| { | |||
| name: "filter", | |||
There was a problem hiding this comment.
This test and the one below it share the same name, so it might be better to change the names to something like filter - no match and filter-success.
DavisFrench
reviewed
Mar 30, 2022
| @@ -23,8 +23,6 @@ Deploy a job. | |||
| const ( | |||
| defaultJobVersion = "v1" | |||
| defaultJobParallelism = 1 | |||
| defaultJobCompletions = 1 | |||
There was a problem hiding this comment.
Was this supposed to be deleted?
DavisFrench
approved these changes
Mar 30, 2022
aleksej-paschenko
approved these changes
Mar 31, 2022
| @@ -12,7 +12,7 @@ spec: | |||
| {{- if $.Values.job.completions }} | |||
| completions: {{ $.Values.job.completions }} | |||
| {{- end }} | |||
| {{- if $.Values.job.backoffLimit }} | |||
| {{- if not (kindIs "invalid" $.Values.job.backoffLimit) }} | |||
itsksaurabh
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes redundant
defaultBackoffLimitfrom CLI. K8s sets the default to 6 when empty. MakesbackoffLimita pointer, permitting passing a0in.Fixes # shipa-2627
Type of change
Testing
Documentation
Final Checklist:
Additional Information (omit if empty)
Please include anything else relevant to this PR that may be useful to know.