[SHIPA-1384] skips notFound error in app watch loop #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating an existing app, especially via
shipa app deploy
, the app watcher loop occasionally emits a WARNING event, indicating that it cannot find the deployment intended to be deleted. It seems to be a race. It's probably fine to just skip this notFound error and let the loop run again.I tested this PR by building & pushing this docker image, using it w/ shipa, and re-deploying an existing app to a new framework.
[shipa-1384]
From logging the error during an app update:
Type of change
Testing
Documentation
Final Checklist: