Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIPA-1384] skips notFound error in app watch loop #241

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Mar 29, 2022

Description

When updating an existing app, especially via shipa app deploy, the app watcher loop occasionally emits a WARNING event, indicating that it cannot find the deployment intended to be deleted. It seems to be a race. It's probably fine to just skip this notFound error and let the loop run again.

I tested this PR by building & pushing this docker image, using it w/ shipa, and re-deploying an existing app to a new framework.

[shipa-1384]

From logging the error during an app update:

2022/03/29 18:27:13 Deleting "a1-web-9" in shipa-system...
ERR <nil> false
2022/03/29 18:27:13 updating status for upgraded release for a1
ERR deployments.apps "a1-web-9" not found true

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@stinkyfingers stinkyfingers merged commit 4b9435e into main Mar 30, 2022
@stinkyfingers stinkyfingers deleted the shipa-1384 branch March 30, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants