Updates helm to 3.6.3

[stinkyfingers]

Description

Updates helm dep to 3.6.3, addressing a vulnerability in <3.6.1. This required updating sigs.k8s.io/controller-runtime to v0.9.5. This change required updates to the Reconciler signatures and Mock Clients. The most common change was a switch from runtime.Object to client.Object. The client.Object inherits the runtime.Object, so their should be no effect. Tested locally and via integration tests.

Fixes # 1692

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Chore (documentation addition or typo, file relocation)

Testing

• New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
• This change requires no testing (i.e. documentation update)

Documentation

• All added public packages, funcs, and types have been documented with doc comments
• I have commented my code, particularly in hard-to-understand areas

Final Checklist:

• I followed standard GitHub flow guidelines
• I have performed a self-review of my own code
• My changes generate no new warnings

[aleksej-paschenko]

what do you think if we return cancel as part of *testingContext to avoid using global vars?

type testingContext struct {
	env *envtest.Environment
	cancel context.CancelFunc
	context.Context
	k8sClient client.Client
}

func setup(reader templates.Reader, helm Helm, objects []client.Object) (*testingContext, error) {
	cancelCtx, cancel := context.WithCancel(context.Background())

	ctx := &testingContext{
		cancel: cancel,
		Context: cancelCtx,
		env: &envtest.Environment{
			CRDDirectoryPaths: []string{filepath.Join("..", "..", "config", "crd", "bases")},
		},
	}

}

[stinkyfingers]

Great call. I'm embarrassed I didn't see it.