Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install ketch CLI on apple m1 machines #120

Merged
merged 1 commit into from
Jul 23, 2021
Merged

install ketch CLI on apple m1 machines #120

merged 1 commit into from
Jul 23, 2021

Conversation

vivek
Copy link
Contributor

@vivek vivek commented Jul 23, 2021

This simple fix enables ketch installation on apple m1 machines. I tested, it works well as apple m1 allows running darwin-amd64 binaries via rosetta2 automatically.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

This simple fix enables ketch installation on apple m1 machines. I tested, it works well as apple m1 allows running darwin-amd64 binaries via rosetta2 automatically.
@vivek vivek requested a review from stinkyfingers July 23, 2021 20:29
@vivek vivek merged commit cb7de0b into main Jul 23, 2021
@vivek vivek deleted the apple-m1-install branch July 23, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants