Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export defaults to stdout + cleanup #118

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Export defaults to stdout + cleanup #118

merged 1 commit into from
Jul 22, 2021

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Jul 20, 2021

Description

  • Adds name to framework when framework is created via cli args.
  • defaults export commands to stdout, rather than yaml file
  • adds omitempty on application.version in yaml pkg to prevent "version: null" when there is no version specified

Fixes # 1626

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

@stinkyfingers stinkyfingers changed the title adds name to framework; defaults export commands to stdout; omitempty… Export defaults to stdout + cleanup Jul 20, 2021
@stinkyfingers stinkyfingers merged commit 708a55f into main Jul 22, 2021
@stinkyfingers stinkyfingers deleted the jds/1626 branch July 22, 2021 15:21
vivek pushed a commit that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants