Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for writing extra fields. #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

acg
Copy link

@acg acg commented Jan 19, 2019

This change lets callers add tagged extra fields to central directory records. For compatibility with yauzl, the shape of extraFields is the same: an Array with each entry of the form {id: id, data: data}.

@andrewrk
Copy link
Collaborator

OMG my old co-worker just made a pull request to my best friend ❤️

@thejoshwolfe
Copy link
Owner

Hi @acg . Sorry for the delayed response. (wow it's been 5 years.) Thanks for the high-quality PR! updating docs and tests is definitely appreciated.

I'm curious which extra fields you want to include in the zip file, or if you want to perhaps preserve all of them that exist in an existing zip file? If the latter, this sounds similar to #38 and #76 .

If you're interested in specific extra fields, the test changes suggest that perhaps the 0x7875 Info-ZIP UNIX (newer UID/GID) extra field is what you want. This is similar to #70 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants