feat: add component, add mark definition to portabletext, including fixes and refactoring #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies to latest version
import type `List` was aliased as the same
Drop `throwError`, fix `style`, and render it as a block element regardless if `isInline` is true
Remove `data-listitem` as it has no purpose
Changed style to a lightyellow box with rounded corners and a drop shadow
Set colour to #310070
Pass only `value` and `components` to component. Refactor `Props` type
It decides which render component to use and uses scoped styles as base styles for render component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Countercomponentlinkmark definition to portable text dataFixes
StackblitzconfigCodeSandboxNode versionRefactored