fix: onMissingComponent prop to accept boolean

theisel · Sep 26, 2022 · 29815b8 · 29815b8
1 parent 0b86d85
commit 29815b8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/.changeset/tall-kings-rush.md b/.changeset/tall-kings-rush.md
@@ -0,0 +1,10 @@
+---
+"astro-portabletext": patch
+---
+
+Fixes PortableText `onMissingComponent` prop to accept boolean
+
+```diff
+- onMissingComponent?: MissingComponentHandler | false;
++ onMissingComponent?: MissingComponentHandler | boolean;
+```
diff --git a/astro-portabletext/components/PortableText.astro b/astro-portabletext/components/PortableText.astro
@@ -55,7 +55,7 @@ const {
   value,
   components: componentOverrides = {},
   listNestingMode = LIST_NEST_MODE_HTML,
-  onMissingComponent = printWarning,
+  onMissingComponent = true,
   class: astroClass,
 } = Astro.props;
 
@@ -99,7 +99,13 @@ const components = mergeComponents(
 ) as PortableTextComponents;
 
 const noop = () => {};
-const missingComponentHandler = onMissingComponent || noop;
+
+const missingComponentHandler = ((handler: unknown) => {
+  if (typeof handler === "function") {
+    return handler;
+  }
+  return !handler ? noop : printWarning;
+})(onMissingComponent);
 
 const emitter = mitt<{
   unknownType: string;

diff --git a/astro-portabletext/src/types.ts b/astro-portabletext/src/types.ts
@@ -43,7 +43,7 @@ export interface PortableTextProps<
    * Prints a warning message to the console by default.
    * Pass `false` to disable.
    */
-  onMissingComponent?: MissingComponentHandler | false;
+  onMissingComponent?: MissingComponentHandler | boolean;
 
   /**
    * `html` or `direct`