Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing double last name failed #30

Closed
rvanlaak opened this issue Nov 6, 2019 · 2 comments
Closed

Parsing double last name failed #30

rvanlaak opened this issue Nov 6, 2019 · 2 comments

Comments

@rvanlaak
Copy link

rvanlaak commented Nov 6, 2019

For the following book the name gets parsed incorrectly:

https://www.bol.com/nl/p/dans/9200000105098508

Etje Heijdanus-De Boer

Expected

Etje Heijdanus-De Boer

Actual

Etje Heijdanus-De Boer
wyrfel added a commit that referenced this issue Nov 6, 2019
@wyrfel
Detect last name prefixes in combined lastname parts (fixes #30)
90e8adc 
This enables the detection of lastnames combined via a dash with
the prefix to a following lastname, e.g. in "Etje Heijdanus-De Boer".
At this point the entire part is treated as Lastname as there is
no support for re-combining last name parts or prefixes.
This means the 'De' prefix in 'De Boer' above cannot be accessed
individually.
@wyrfel
Copy link
Contributor

wyrfel commented Nov 6, 2019 •
edited
Loading

Fixed in #31. Not fully happy with the solution, but should be good enough for now. Again, this points to a need for the part splitting to be smarter.

wyrfel added a commit that referenced this issue Nov 6, 2019
@wyrfel
Detect last name prefixes in combined lastname parts (fixes #30)
9597ff7 
This enables the detection of lastnames combined via a dash with
the prefix to a following lastname, e.g. in "Etje Heijdanus-De Boer".
At this point the entire part is treated as Lastname as there is
no support for re-combining last name parts or prefixes.
This means the 'De' prefix in 'De Boer' above cannot be accessed
individually.
@wyrfel wyrfel closed this as completed in 3432592 Nov 6, 2019
wyrfel added a commit that referenced this issue Nov 6, 2019
@wyrfel
Merge pull request #31 from theiconic/feature/detect-lastname-prefix-…
1961d10 
…in-combined-parts

Detect last name prefixes in combined lastname parts (fixes #30)
@rvanlaak
Copy link
Author

rvanlaak commented Nov 6, 2019

Thank you @wyrfel 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wyrfel @rvanlaak