♻️ Migrate core tests to native node test runner #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha is not maintained, monkey patches `require()`, and mucks with the module loader. Meanwhile, Node has a native test runner that is fast, reliable, and actively maintained as part of the Node JS project. This gets rid of `ts-node` and `mocha` in favor of `tsx` and the native runner. Most of the time this involves just importing from `node:test` instead of `mocha`. In cases where `mocha` was mushing its hooks onto the global scope (`beforeEach()`, `afterEach()`, et al.) the function has been explicitly imported from `node:test`.
|
✅ Deploy Preview for interactors canceled.
|
wKich
approved these changes
Mar 7, 2024
|
I went ahead and updated the remaining packages because it was so easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mocha is not maintained, monkey patches
require(), and mucks with the module loader. Meanwhile, Node has a native test runner that is fast, reliable, and actively maintained as part of the Node JS project.Approach
This gets rid of
ts-nodeandmochain favor oftsxand the native runner. Most of the time this involves just importing fromnode:testinstead ofmocha.In cases where
mochawas mushing its hooks onto the global scope (beforeEach(),afterEach(), et al.) the function has been explicitly imported fromnode:test.TODOs and Open Questions
--no-deprecationflag to the test script because a library used bytsxis using a library calledpsithat is apparently using a deprecated node API.Learning
Node test runner docs: https://nodejs.org/api/test.html