dnf: consistenty use -y #2116
Merged
dnf: consistenty use -y #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Nov 17, 2023
| @@ -27,7 +27,7 @@ To set up the repository, foreman-release packages are provided which add a repo | |||
|
|
|||
| # EL8 | |||
| dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm | |||
There was a problem hiding this comment.
this install is not using -y, so using -y in the line below seems odd
There was a problem hiding this comment.
bastelfreak@bastelfreak-nb ~/code/theforeman.org $ git grep 'dnf install https:'
_includes/manuals/3.4/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.5/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.6/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.7/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.8/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/nightly/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
bastelfreak@bastelfreak-nb ~/code/theforeman.org $ git grep 'dnf -y install https:'
_includes/manuals/1.12/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm
_includes/manuals/1.13/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm
_includes/manuals/1.14/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm
_includes/manuals/1.15/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm
_includes/manuals/3.3/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.3/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.4/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.4/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.5/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.5/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.6/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.6/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.7/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.7/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/3.8/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/3.8/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
_includes/manuals/nightly/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm
_includes/manuals/nightly/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm
scripts/installer/Dockerfile:RUN dnf -y install https://yum.puppetlabs.com/puppet7/puppet7-release-el-8.noarch.rpm
scripts/installer/Dockerfile:RUN dnf -y install https://yum.theforeman.org/releases/$FOREMAN_VERSION/el8/x86_64/foreman-release.rpm
bastelfreak@bastelfreak-nb ~/code/theforeman.org $
I will fix that in another commit
The installation guidelines use `-y` for all dnf/yum operations, except for enabling the module. DNF support `-y` here as well, so we can use it.
This was a bit inconsistent across the different versions: ``` bastelfreak@bastelfreak-nb ~/code/theforeman.org $ git grep 'dnf install https:' _includes/manuals/3.4/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.5/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.6/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.7/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.8/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/nightly/3.3.1_rpm_packages.md: dnf install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm bastelfreak@bastelfreak-nb ~/code/theforeman.org $ git grep 'dnf -y install https:' _includes/manuals/1.12/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm _includes/manuals/1.13/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm _includes/manuals/1.14/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm _includes/manuals/1.15/2.1_quickstart_installation.md:dnf -y install https://yum.theforeman.org/releases/{{page.version}}/f24/x86_64/foreman-release.rpm _includes/manuals/3.3/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.3/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.4/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.4/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.5/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.5/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.6/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.6/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.7/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.7/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/3.8/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/3.8/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm _includes/manuals/nightly/2.1_quickstart_installation.md:sudo dnf -y install https://yum.puppet.com/puppet7-release-el-8.noarch.rpm _includes/manuals/nightly/2.1_quickstart_installation.md:sudo dnf -y install https://yum.theforeman.org/releases/{{page.version}}/el8/x86_64/foreman-release.rpm scripts/installer/Dockerfile:RUN dnf -y install https://yum.puppetlabs.com/puppet7/puppet7-release-el-8.noarch.rpm scripts/installer/Dockerfile:RUN dnf -y install https://yum.theforeman.org/releases/$FOREMAN_VERSION/el8/x86_64/foreman-release.rpm bastelfreak@bastelfreak-nb ~/code/theforeman.org $ ``` I will fix that in another PR
evgeni
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation guidelines use
-yfor all dnf/yum operations, except for enabling the module. DNF support-yhere as well, so we can use it.