-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puppet_metadata to ~> 4.0 and voxpupuli-acceptance to ~> 3.0 #347
Conversation
Looks like an update that starts to require PostgreSQL 13 was done and we don't set that up on EL8 (EL9 defaults to PG 13):
So that isn't related to this PR, but something we should address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I know why again: the Hiera hierarchy changed in the major version. It's now https://github.com/voxpupuli/voxpupuli-acceptance?tab=readme-ov-file#hiera so you'll need to move spec/acceptance/hieradata/os
. Effectively reverting c16ddb8
For the new version of PostgreSQL 13, how we can do that? Do we have to define new variable based on OS release or how you preferred to do this @ekohl ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also squash it into a single commit since this is a single change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the hierarchy as specified in https://github.com/voxpupuli/voxpupuli-acceptance/?tab=readme-ov-file#hiera. Now it's not in the right path which means it isn't loaded and causing failures.
e992569
to
6b5f701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @ekohl ?
spec/spec_helper_acceptance.rb
Outdated
@@ -14,4 +14,27 @@ | |||
end | |||
end | |||
|
|||
RSpec.configure do |c| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what I meant. I've already tried telling you in #347 (review) that you need to move https://github.com/theforeman/puppet-pulpcore/blob/master/spec/acceptance/hieradata/os/RedHat/8.yaml because version 3 of voxpupuli-acceptance
ends up using a different hierarchy. Rather than overriding the hierarchy to the old style, you should move the file.
In practice what you need to do is exactly the reverse of c16ddb8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekohl I am not sure what I was missing out but isn't my this change archanaserver@9f884fb was exactly reverting 4248c03 one?
Also I'm not sure if I did the right thing now, but i did revert this specific c16ddb8 and pushed it and I can see this now "Skipping EOL operating system CentOS 8"
6b5f701
to
1a5fe9a
Compare
As discussed elsewhere: c16ddb8 used a dash in |
Revert "move the hiera file at the right place" This reverts commit c16ddb8.
1a5fe9a
to
957d742
Compare
@ekohl it is passing all the tests now. thanks! |
No description provided.