Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppet_metadata to ~> 4.0 and voxpupuli-acceptance to ~> 3.0 #347

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

archanaserver
Copy link
Contributor

No description provided.

@ekohl
Copy link
Member

ekohl commented Jul 3, 2024

Looks like an update that starts to require PostgreSQL 13 was done and we don't set that up on EL8 (EL9 defaults to PG 13):

  Notice: /Stage[main]/Pulpcore::Database/Pulpcore::Admin[migrate --noinput]/Exec[pulpcore-manager migrate --noinput]/returns: django.db.utils.NotSupportedError: PostgreSQL 12 or later is required (found 10.23).

So that isn't related to this PR, but something we should address.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I know why again: the Hiera hierarchy changed in the major version. It's now https://github.com/voxpupuli/voxpupuli-acceptance?tab=readme-ov-file#hiera so you'll need to move spec/acceptance/hieradata/os. Effectively reverting c16ddb8

@archanaserver
Copy link
Contributor Author

archanaserver commented Jul 12, 2024

Looks like an update that starts to require PostgreSQL 13 was done and we don't set that up on EL8 (EL9 defaults to PG 13):
Notice: /Stage[main]/Pulpcore::Database/Pulpcore::Admin[migrate --noinput]/Exec[pulpcore-manager migrate --noinput]/returns: django.db.utils.NotSupportedError: PostgreSQL 12 or later is required (found 10.23).
So that isn't related to this PR, but something we should address.

For the new version of PostgreSQL 13, how we can do that? Do we have to define new variable based on OS release or how you preferred to do this @ekohl ?

archanaserver added a commit to archanaserver/puppet-pulpcore that referenced this pull request Jul 12, 2024
archanaserver added a commit to archanaserver/puppet-pulpcore that referenced this pull request Jul 12, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also squash it into a single commit since this is a single change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the hierarchy as specified in https://github.com/voxpupuli/voxpupuli-acceptance/?tab=readme-ov-file#hiera. Now it's not in the right path which means it isn't loaded and causing failures.

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ekohl ?

@@ -14,4 +14,27 @@
end
end

RSpec.configure do |c|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I meant. I've already tried telling you in #347 (review) that you need to move https://github.com/theforeman/puppet-pulpcore/blob/master/spec/acceptance/hieradata/os/RedHat/8.yaml because version 3 of voxpupuli-acceptance ends up using a different hierarchy. Rather than overriding the hierarchy to the old style, you should move the file.

In practice what you need to do is exactly the reverse of c16ddb8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl I am not sure what I was missing out but isn't my this change archanaserver@9f884fb was exactly reverting 4248c03 one?

Also I'm not sure if I did the right thing now, but i did revert this specific c16ddb8 and pushed it and I can see this now "Skipping EOL operating system CentOS 8"

@ekohl
Copy link
Member

ekohl commented Jul 24, 2024

As discussed elsewhere: c16ddb8 used a dash in RedHat-8.yaml but according to https://github.com/voxpupuli/voxpupuli-acceptance?tab=readme-ov-file#hiera it needs to be a file in the subdirectory (so a slash).

Revert "move the hiera file at the right place"

This reverts commit c16ddb8.
@archanaserver
Copy link
Contributor Author

@ekohl it is passing all the tests now. thanks!

@ehelms ehelms merged commit d034f03 into theforeman:master Jul 30, 2024
17 checks passed
@ekohl ekohl added the Enhancement New feature or request label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants