Fixes #33445: Increase default API gunicorn worker count #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 4, 2021
There was a problem hiding this comment.
👍 for this in general, but could you this line:
puppet-pulpcore/spec/classes/pulpcore_spec.rb
Line 128 in 13c10a3
is_expected.to contain_systemd__unit_file('pulpcore-api.service').with_content(%r{-w 2})That should verify that when there's 1 processor (see line 6) it has 2 workers.
This increases the default API gunicorn worker count to be similar to that of content worker count but with a smaller minimum. There are different workloads that can require higher throughput through the API and the current default of 1 is too low of a starting point.
439b58c to
bee2af1
Compare
|
updated with test! |
ekohl
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the default API gunicorn worker count to be similar
to that of content worker count but with a smaller minimum. There
are different workloads that can require higher throughput through
the API and the current default of 1 is too low of a starting point.