Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pulpcore-manager #111

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Use pulpcore-manager #111

merged 2 commits into from
Jul 16, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 14, 2020

This requires at least Pulp 3.2.0, but since f59265e that's been the required minimum version.

spec/defines/admin_spec.rb Outdated Show resolved Hide resolved
spec/defines/admin_spec.rb Outdated Show resolved Hide resolved
spec/defines/admin_spec.rb Outdated Show resolved Hide resolved
@wbclark
Copy link
Collaborator

wbclark commented Jul 15, 2020

On my test machine, I am getting the expected output when running $ sudo PULP_SETTINGS=/etc/pulp/settings.py pulpcore-manager dumpdata auth.User

I think this is good to go once tests are fixed. Thanks @ekohl ! :)

@ekohl
Copy link
Member Author

ekohl commented Jul 15, 2020

@evgeni does it make sense to push for that PULP_SETTINGS default somewhere so users don't need to remember it for system wide installs?

@evgeni
Copy link
Member

evgeni commented Jul 15, 2020

Maybe? Probably better to ask the Pulp team though.

@ehelms
Copy link
Member

ehelms commented Jul 15, 2020

Sigh, it does. Let's file an issue (and/or open a PR to add this with a default to the standard system path to make life easier for all).

This requires at least Pulp 3.2.0, but since
f59265e that's been the required
minimum version.
@ekohl ekohl force-pushed the pulpcore-manager branch from cdc2046 to fbeae28 Compare July 16, 2020 12:02
Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekohl
Copy link
Member Author

ekohl commented Jul 16, 2020

@bmbouter suggested we should also execute the admin command as the pulp user rather than root. I'll add that as well.

@ekohl ekohl merged commit 8c66bff into theforeman:master Jul 16, 2020
@ekohl ekohl deleted the pulpcore-manager branch July 16, 2020 16:17
@ekohl ekohl added the Enhancement New feature or request label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants