Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial setup via modulesync #1

Merged
merged 1 commit into from
Oct 30, 2019
Merged

initial setup via modulesync #1

merged 1 commit into from
Oct 30, 2019

Conversation

wbclark
Copy link
Collaborator

@wbclark wbclark commented Oct 29, 2019

No description provided.

@evgeni
Copy link
Member

evgeni commented Oct 30, 2019

slightly related, this repo needs travis enabled :)

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis has been enabled

@ehelms ehelms merged commit 73116a4 into theforeman:master Oct 30, 2019
@ekohl
Copy link
Member

ekohl commented Oct 30, 2019

Maybe it was modulesync, but it looks like you submitted the PR from your master branch. Usually it's better to create a separate branch for every PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants