Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass $deployment_url to candlepin #214

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Don't pass $deployment_url to candlepin #214

merged 1 commit into from
Sep 13, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 12, 2017

This is unused and theforeman/puppet-candlepin#82 was opened to remove this parameter.

@ekohl
Don't pass $deployment_url to candlepin
6c88e13 
This is unused and theforeman/puppet-candlepin#82
was opened to remove this parameter.
@ekohl ekohl force-pushed the remove-candlepin-deployment-url branch from 151f404 to 6c88e13 Compare September 12, 2017 11:24
sean797
sean797 approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@sean797 sean797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ekohl ekohl merged commit 6c88e13 into theforeman:master Sep 13, 2017
@ekohl ekohl deleted the remove-candlepin-deployment-url branch September 13, 2017 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

@sean797 sean797 sean797 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @chris1984 @sean797