Fixes #32160 - enable ansible content #343
Conversation
|
We'll need to update metadata.json as well to depend on a version that includes the new code. That probably requires theforeman/puppet-pulpcore#184 to be merged and a version bump, at least in git. After that I also think the tests should pass. |
|
yes, i will likely bump the requires in #342 first once the new version is released and then re-test this one |
| @@ -12,6 +12,8 @@ | |||
| # | |||
| # $enable_deb:: Enable debian content plugin | |||
| # | |||
| # $enable_ansible:: Enable ansible content plugin | |||
There was a problem hiding this comment.
Is the discrepancy in naming intentional? In the Katello application itself, the setting is enable_ansible_collection (https://github.com/theforeman/puppet-katello/pull/401/files#diff-510884a7414666a0d988133c5f869510210d883aa1580d1248e74f1d16ca7d91R13)
There was a problem hiding this comment.
yes, this is intentional. the pulp plugin is called 'ansible', but provides two different types of 'repositories' (really remotes/distributors), ansible_collections and ansible_roles. Katello only supports ansible_collections at this time, and would likely implement roles as a different repo type (if we ever implement support)
|
You can now update https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/metadata.json#L37 to a minimum of |
|
will rebase once #342 goes in |
081a6d4 to
e7b4407
Compare
|
went ahead and rebased this and updated metadata.json, so which ever goes in first is fine |
No description provided.