Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test #99

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Acceptance test #99

merged 2 commits into from
Feb 22, 2018

Conversation

sean797
Copy link
Member

@sean797 sean797 commented Feb 22, 2018

Certs are a little ugly, we can probably do better in the future.

ekohl
ekohl approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. puppet-lint isn't very happy with the example, but otherwise I think this is a good addition.

@sean797 sean797 merged commit f6298a7 into theforeman:master Feb 22, 2018
@sean797 sean797 deleted the acceptance-test branch February 22, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean797 @ekohl @theforeman-bot