Add baseurl parameter to repo class #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Nov 17, 2023
ekohl
requested changes
Nov 17, 2023
|
@ekohl Could you re-review? |
ekohl
requested changes
Dec 19, 2023
ekohl
reviewed
Dec 19, 2023
39e861b to
e5ccc6e
Compare
ekohl
reviewed
Jan 3, 2024
|
I added a new commit that does the URL change. |
ekohl
reviewed
Jan 10, 2024
spec/setup_acceptance_node.pp
Outdated
| @@ -5,7 +5,7 @@ | |||
| } | |||
|
|
|||
| class { 'candlepin::repo': | |||
| version => pick(fact('candlepin_version'), 'nightly'), | |||
| version => pick(fact('candlepin_version'), '4.3'), | |||
There was a problem hiding this comment.
The nightly one is empty right now, as we have no dedicated candlepin test and publish pipeline yet
There was a problem hiding this comment.
Basically yes, I wanted to test and for this to work from a known working point in time. Then to use this new feature to enable the testing pipelines.
There was a problem hiding this comment.
I have a working nightly repository for EL8 now, so I reverted this change back.
evgeni
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support setting this value to our staging repositories for testing of new builds of Candlepin.