Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Puppet 8 support #240

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add Puppet 8 support #240

merged 3 commits into from
Nov 8, 2023

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Aug 4, 2023 •
edited
Loading

also contains #239

ekohl
ekohl requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need #241.

ekohl
ekohl requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@bastelfreak
Copy link
Member Author

@ekohl rebased on #239

@ekohl ekohl merged commit bad7d8b into theforeman:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
Puppet 8 installer support
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @theforeman-bot