Ensure maven:3.8 is enabled on EL8 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jul 17, 2023
|
Idempotency is failing with this change and I am not sure why. Perhaps this has something to do with how Puppet handles when a profile is provided, aka |
ekohl
reviewed
Jul 17, 2023
1ed216c to
5db4ea9
Compare
|
Thanks for feedback @ekohl - I got this green with the change test added that helped. |
ekohl
approved these changes
Jul 18, 2023
| it { should be_owned_by 'tomcat' } | ||
| it { should be_grouped_into 'tomcat' } | ||
| its(:content) { should eq("katelloUser=CN=ActiveMQ Artemis Deferred, OU=Artemis, O=ActiveMQ, L=AMQ, ST=AMQ, C=AMQ\n") } | ||
| context 'when swapping to maven 3.8' do |
There was a problem hiding this comment.
Rather than restructuring the whole file, could this be spec/acceptance/dnf_module_spec.rb?
The maven 3.5 and 3.6 modules are no longer supported on RHEL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maven 3.5 and 3.6 modules are no longer supported on RHEL.