-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete CRLUpdateJob options #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README today is very sparse. In other modules we have some sort of compatibility. While this doesn't appear to drop the compatibility with older versions (just remove the option to configure the job), it might be nice to get some indication.
https://github.com/theforeman/puppet-pulpcore#support-policy is one example. theforeman/puppet-pulpcore@137128e#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 shows how we did deal with multiple versions when we had differences.
@ekohl ready fore review & merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is this something that should be cherry picked at some point or is it only for nightly? For cherry picks a Redmine issue is a lot easier, for nightly I don't care as much. Given it's removing something I think it's nightly only, but you probably know.
Just nightly :) |
@ekohl merge? :) |
The next (or otherwise upcoming) Candlepin release removes the CRLUpdateJob in favor of CertificateUpdateJob. The new job doesn't write any sort of CRL so we don't need to disable it.
Opening this as a draft so it doesn't get merged and so I don't forget to have this merged when the time comes :)