-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAT-24015] Remove telemetry option from conversion templates #889
[SAT-24015] Remove telemetry option from conversion templates #889
Conversation
/packit build |
@@ -25,10 +16,6 @@ if ! rpm -q convert2rhel &> /dev/null; then | |||
yum install -y convert2rhel | |||
fi | |||
|
|||
<% if input('Data telemetry') != "yes" -%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hosekadam Does this affect instances that are disconnected from the internet?
What will happen if the telemetry cannot be uploaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert2RHEL doesn't collect this env var anymore (removed in oamg/convert2rhel#1102) so having the env var doesn't make any difference.
And about your question: the telemetry is now handled by the subscription-manager
and if it fails a warning is printed.
There is also a migration results file saved to /etc/migration-results
, but I'm not sure how/if it's being collected. Maybe @bocekm would know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @hosekadam wrote, convert2rhel now always generates a /etc/rhsm/facts/convert2rhel.facts file and then it's up to subscription-manager to upload it to Candlepin (the Red Hat hosted one or the Foreman's on-premise one). So the facts file is collected even if the host registered to Foreman is disconnected from the internet. I'm now talking to a few Satellite folks to make sure that the Satellite's rh_cloud plugin uploads these conversion facts to Insights so that we account for conversions of the systems registered to Satellite in our metrics. If I got it correctly, customers will be able to opt out of this data collection by disabling the rh_cloud plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks
Thank you @hosekadam ! |
(cherry picked from commit ce89be1)
(cherry picked from commit ce89be1)
Remove the telemetry opt out since it's not being used by Convert2RHEL anymore.
https://issues.redhat.com/browse/SAT-24015