Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin version 0.8 breaks GCE compute resource plugin #87

Closed
pdzionek opened this issue Jun 4, 2019 · 2 comments
Closed

Plugin version 0.8 breaks GCE compute resource plugin #87

pdzionek opened this issue Jun 4, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@pdzionek
Copy link

pdzionek commented Jun 4, 2019

Describe the bug
When a proxmox plugin is installed it messes up with GCE plugin and breaks it. This issue was described here: Foreman Forum in last few posts

Quote from the last post by @tbrisker:

I’m afraid this would need to be fixed in the plugin, i think at https://github.com/theforeman/foreman_fog_proxmox/blob/master/app/views/compute_resources_vms/form/proxmox/_add_vm_type_to_volumes_edit.html.erb#L18. The plugin seems to assume that all compute resources have a type method, which apparently isn’t the case for GCE. There may be other assumptions done inside the plugin that will need to be fixed as well, i’m not familiar with its internals.

FYI,
I am using latest foreman 1.22 rc2 and 0.8 version of this plugin.

@tristanrobert tristanrobert added the bug Something isn't working label Aug 3, 2019
@tristanrobert tristanrobert added this to the 0.8.1 milestone Aug 3, 2019
@m-bucher
Copy link
Contributor

m-bucher commented Oct 1, 2019

This also breaks other Compute-Resources like libvirt.
As far as I see it, this is due to the usage of Deface to introduce the VM-type into the compute_resource_vms views.

The best solution in my opinion would be to get rid of defacing the type-parameter into the views.
Could this be possible by adding the type to the basic compute-resource definition, rather than letting the user decide in the host-create form?

@tristanrobert
Copy link
Collaborator

A conditional deface on provision compute (compute = proxmox) should be added. PRs are welcome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants