content_view_filter_rule module #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Feb 10, 2023
Comment on lines
325
to
330
| # if the state is present and the module_id IS in the list, | ||
| # make sure that the current and desired state are identical | ||
| else: | ||
| content_view_filter_rule = module.foreman_params |
There was a problem hiding this comment.
This shouldn't be necessary (but it is), so worth investigating further.
evgeni
commented
Feb 10, 2023
parmstro
approved these changes
Feb 10, 2023
benformosa
added a commit
to benformosa/foreman-ansible-modules
that referenced
this pull request
Jun 19, 2023
Update the content_views role to allow content view filters to have multiple rules, using the module added in theforeman#1558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out of #1547